#78 Adds update to remove newsletter view #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I modified the developer sandbox to re-introduce this bug so we should be able to test the update: |
jcsparks
approved these changes
Jan 15, 2025
Member
jcsparks
left a comment
jcsparks
left a comment
There was a problem hiding this comment.
Looks like it successfully disables the newsletter_by_type View.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
#78 Adds update to remove newsletter view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously disabling the "Newsletters by Type" view would continue to cannibalize the "Taxonomy Terms" view page and result in a blank page due to both views sharing a path by default. This could only be disabled by changing the path, then disabiling the view on live sites, in order to correctly render the taxonomy view.
This update hook should disable the newsletter-specific view and allow the taxonomy view to handle all terms correctly, after running a
drush updbcommand on the live sitesResolves #78